From 65844e1e8caed8f7f55bc149b1406c19f4907488 Mon Sep 17 00:00:00 2001 From: tsteven4 Date: Fri, 1 Jun 2018 09:33:13 -0600 Subject: [PATCH] clang-tidy replaces integer literals that are cast to bool. -header-filter=.*\\.h -checks=-*,modernize-use-bool-literals -fix --- jeeps/gpslibusb.cc | 4 ++-- util.cc | 6 +++--- xcsv.cc | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/jeeps/gpslibusb.cc b/jeeps/gpslibusb.cc index 04de63af9..f0fa63bf5 100644 --- a/jeeps/gpslibusb.cc +++ b/jeeps/gpslibusb.cc @@ -231,7 +231,7 @@ gusb_reset_toggles(void) gusb_cmd_send((const garmin_usb_packet*) oinit, sizeof(oinit)); t = 10; - while (1) { + while (true) { le_write16(&iresp.gusb_pkt.pkt_id, 0); le_write32(&iresp.gusb_pkt.datasz, 0); le_write32(&iresp.gusb_pkt.databuf, 0); @@ -256,7 +256,7 @@ gusb_reset_toggles(void) t = 10; gusb_cmd_send((const garmin_usb_packet*) oid, sizeof(oid)); - while (1) { + while (true) { le_write16(&iresp.gusb_pkt.pkt_id, 0); le_write32(&iresp.gusb_pkt.datasz, 0); le_write32(&iresp.gusb_pkt.databuf, 0); diff --git a/util.cc b/util.cc index 3d6d93e0d..fec26db50 100644 --- a/util.cc +++ b/util.cc @@ -1741,16 +1741,16 @@ entitize(const char* str, bool is_html) char* xml_entitize(const char* str) { - return entitize(str, 0); + return entitize(str, false); } char* html_entitize(const char* str) { - return entitize(str, 1); + return entitize(str, true); } char* html_entitize(const QString& str) { - return entitize(CSTR(str), 1); + return entitize(CSTR(str), true); } /* diff --git a/xcsv.cc b/xcsv.cc index 583f51d1c..6b259810c 100644 --- a/xcsv.cc +++ b/xcsv.cc @@ -513,7 +513,7 @@ void xcsv_read_internal_style(const char* style_buf) { xcsv_file_init(); - xcsv_file.is_internal = 1; + xcsv_file.is_internal = true; xcsv_parse_style_buff(style_buf); -- 2.30.2